Skip to content

Conversation

@robin-nitrokey
Copy link
Member

This patch splits the trussed-auth crate into two crates: trussed-auth only defines the AuthExtension and can be used by clients or other backends implementing the extension. trussed-auth-backend contains the AuthBackend that implements the extension using the filesystem.

Copy link
Contributor

@sosthene-nitrokey sosthene-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be constistent with the other extensions/backends.

The implementation goes at the top level, the extension goes in to an extension top-level directory.

I fundamentally don't care much for it, but It should be consistent across crates.

@robin-nitrokey
Copy link
Member Author

I think the main difference to the other repositories is that in this case, the extension is the main component, not the backend. So what should, for example, happen with the changelog? It would be consistent to have the backend changelog in . and the extension changelog in extension, but I would find it confusing if the root changelog exists but does not contain the changes for the main crate of the repository.

@robin-nitrokey
Copy link
Member Author

@sosthene-nitrokey Do you still want to move the backend to the top level?

@daringer
Copy link
Member

this might be worth doing towards the next test releases, added it... I'd cast my vote against moving the backend to top-lvl, but it's max a 1/2 vote

@sosthene-nitrokey
Copy link
Contributor

Ok, then it's 2/1 so let's keep it the way it is.

This patch splits the trussed-auth crate into two crates:  trussed-auth
only defines the AuthExtension and can be used by clients or other
backends implementing the extension.  trussed-auth-backend contains the
AuthBackend that implements the extension using the filesystem.
@robin-nitrokey robin-nitrokey merged commit 2fc6856 into trussed-dev:main Jan 21, 2025
1 check passed
@robin-nitrokey robin-nitrokey deleted the split branch January 21, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants