Conversation
|
Thanks for the PR! Sorry not taking a look at this earlier. I'll give it a manual try and check. |
|
Ok, I tried to use this in a way like: However, it won't work. As our examples also have a configuration and have the I am wondering what the use case of that PR in its current form would be? |
the PR is quite minimal and doesn't introduce any special considerations for how examples are organized, e.g. like the examples in this repo are, with separate for example, i released a vendored version of trunk here https://github.com/databasedav/trunk/releases/tag/v0.0.1, which i use in my ci here https://github.com/databasedav/haalka/blob/dd675822a9441f343be64cd280b8c69cb92fc44c/.github/workflows/build_and_deploy_example.yaml#L29 to run a the generated files are viewable (for example) here https://github.com/databasedav/haalka/tree/0b77b1686637ea77659e8a7f61c2ede34e75d263/examples/webgl2/counter and served via github pages here https://databasedav.github.io/haalka/examples/webgl2/counter/ i think having |
6d948c8 to
b4afb88
Compare
rebased version of #457
resolves #423