This repository was archived by the owner on Feb 9, 2024. It is now read-only.
Conversation
Updated dependency versions, updated print statements and changed iteration iteration operations on various dicts (in the creation of option_defaults for example) in order for the module to run on python 3.7.something. There have been no attempts to improve much else, since that is not my goal, though it is evident that much work is required to bring the module to a state by which it could be said to "work reliably". To me, getting the module to run is enough; effort is better spent creating a cdk module or somethin' idk byeeeeeeeeeeeeee
Author
|
@thesamet is there anything stopping this from being merged? |
Contributor
|
Hi @mikey- , I'm no longer with TrueAccord so I am unable to merge. I am not sure if this project is still in use. |
Author
|
@thesamet fair enough :) Thanks for getting back to me anyway. I'll continue to use my fork I suppose. |
Author
|
@aplsms is this project still in use? |
terrafying
approved these changes
Dec 29, 2022
Author
|
Thanks @terrafying :) @moimikey is this something you can approve also? |
Author
|
@moimikey do you have any issues with the changes here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been a while since someone made a PR for this, so I figured since I was looking into it, I'd give it a crack...
Updated dependency versions, updated print statements and changed
iteration iteration operations on various dicts (in the creation
of option_defaults for example) in order for the module to run
on python 3.7.something.
There have been no attempts to improve much else, since that is not my
goal.
cheeeerrrrrzzzzzzzz and thank you