fix(fuzz): link http_protocol_handlers.c + grpc.c into embedded harnesses#112
Merged
Conversation
…sses fuzz_http1_parser / fuzz_h2_session failed at link time — http_parser.c's on_headers_complete calls http_request_classify_protocols and http_request_body_must_buffer (src/core/http_protocol_handlers.c), which in turn calls grpc_request_mode (src/grpc/grpc.c). Neither TU was in the harness source list, so the CI 'Fuzz embedded' job was red at link. Both TUs are self-contained (PHP-core symbols only, no server-side deps), so add them to HTTP1_SRC and H2_SRC rather than stubbing — the fuzzer now exercises real gRPC classification. Verified: both harnesses build and link; fuzz_http1_parser runs 50 iterations clean (cov 91->255, no crash).
Contributor
CoverageTotal lines: 80.84% → 81.11% (+0.27 pp)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the pre-existing red Fuzz embedded CI job (link failure, introduced with #109).
http_parser.c'son_headers_completecallshttp_request_classify_protocols/http_request_body_must_buffer(src/core/http_protocol_handlers.c), which callgrpc_request_mode(src/grpc/grpc.c). Neither TU was in the harness source list.Both TUs are self-contained (PHP-core symbols only), so added to
HTTP1_SRC+H2_SRCrather than stubbed — fuzzer now exercises real gRPC classification.Verified: both harnesses build+link;
fuzz_http1_parserruns 50 iters clean (cov 91→255, no crash).