reload: worker-retire lifecycle logs + document persistent-coroutine SIGSEGV (#93)#102
Merged
Merged
Conversation
…coroutine reload SIGSEGV (#93) Pairs with the ext/async fix that graceful-shuts-down a retiring sync worker so HttpServer::reload() no longer deadlocks when the bootloader left a long-lived coroutine (e.g. an async DB-pool healthcheck timer). - Log `worker shutting down (reason=reload, grace=Ns)` at retire and rename the bare `worker thread exited cleanly` to `worker exited`, so the journal reads `shutting down → exited` per worker instead of a confusing run of "exited cleanly" that looked like a failure. - docs/ISSUE_reload_persistent_coroutine_segv.md — full writeup of the remaining, not-yet-fixed intermittent SIGSEGV during rotation (proven: a valid persistent coroutine first-started with a NULL run-time cache), a repro, ruled-out theories, a failed fix attempt, and open questions. - Fix a -Wcomment warning from a stray "/*" in a header comment.
… cause (php-async#176) (#93)
Contributor
CoverageTotal lines: 74.28% → 74.28% (-0.00 pp)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with true-async/php-async#177 (graceful-shutdown of a retiring sync worker so
HttpServer::reload()no longer deadlocks when the bootloader left a long-lived coroutine, e.g. an async DB-pool healthcheck timer).worker shutting down (reason=reload, grace=Ns)at retire and rename the bareworker thread exited cleanlytoworker exited, so the journal readsshutting down → exitedper worker instead of a confusing run of "exited cleanly" that looked like a failure.docs/ISSUE_reload_persistent_coroutine_segv.md— writeup + repro of the remaining intermittent SIGSEGV during rotation (root-caused as an ext/async nested-closure bug: Nested closures (dynamic_func_defs) are shared across worker threads on thread transfer → cross-thread run_time_cache use-after-free (SEGV) php-async#176), a repro, and open questions.-Wcommentwarning from a stray/*in a header comment.Verified: real laravel-spawn server 10/10 reloads clean; hot-reload phpt 5/5.