Skip to content

opcache: free transient linked class copy on inheritance-cache race (ZTS) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdmondDantes wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

opcache: free transient linked class copy on inheritance-cache race (ZTS) #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ext/opcache/ZendAccelerator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2400,6 +2400,12 @@ static zend_class_entry* zend_accel_inheritance_cache_add(zend_class_entry *ce,
SHM_PROTECT();
if (!needs_autoload) {
zend_map_ptr_extend(ZCSG(map_ptr_last));
/* Another thread cached this class first; our transient linked
* copy is now unreachable. The MISS path frees it inside persist
* (zend_shared_memdup_free), so the HIT path must free it here. */
zval zv_ce;
ZVAL_PTR(&zv_ce, ce);
destroy_zend_class(&zv_ce);
return entry->ce;
} else {
return NULL;
Expand Down
Loading