Skip to content

fix(future): race-safe remote_future_dispose — sever producer under the mutex before closing the trigger (true-async/server#93) #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdmondDantes merged 1 commit into from
Jul 7, 2026
Merged

fix(future): race-safe remote_future_dispose — sever producer under the mutex before closing the trigger (true-async/server#93) #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion future.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2216,10 +2216,23 @@ static bool remote_future_dispose(zend_async_event_t *event)
zend_future_t *future = &remote->future;

if (remote->state != NULL) {
/* Sever the producer under the mutex before closing the trigger, so a
* concurrent complete() becomes a no-op (mirrors state_object_free). */
zend_async_trigger_event_t *trigger_to_dispose = NULL;

ASYNC_MUTEX_LOCK(remote->state->mutex);
if (remote->state->trigger != NULL) {
remote->state->trigger->base.dispose(&remote->state->trigger->base);
trigger_to_dispose = remote->state->trigger;
remote->state->trigger = NULL;
zend_atomic_int_store(&remote->state->completed, 1);
}
remote->state->target_future = NULL;
ASYNC_MUTEX_UNLOCK(remote->state->mutex);

if (trigger_to_dispose != NULL) {
trigger_to_dispose->base.dispose(&trigger_to_dispose->base);
}

async_future_shared_state_delref(remote->state);
remote->state = NULL;
}
Expand Down
Loading