refactor(thread_pool): drop the now-redundant volatile locals (true-async/server#93)#179
Merged
Merged
Conversation
… the nested zend_try into helpers already clears -Wmaybe-uninitialized; trim comments (true-async/server#93)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #178. Splitting the two inner
zend_tryblocks into helpers already removes the nesting that made GCC misfire-Wmaybe-uninitialized, so thevolatileon the five loop-locals (state,snapshot,worker_coro,task_scope,body_bailed) is dead weight — verified 0-O2warnings without it. Drops thosevolatileand trims the explanatory comments to one line. The helpers keep their ownvolatile bool bailed(that flag is set inzend_catchafter the longjmp and read on return — genuinely setjmp-live).thread_poolsuite 78/79 (pre-existing XFAIL WARN), behavior unchanged.