Xml parse exception#214
Open
droletmarc wants to merge 6 commits intotroydavisson:masterfrom
Open
Conversation
added 6 commits
July 14, 2017 08:24
on each rets request. This file is not used anymore once we get the gets server response and it didn't get removed. - /tmp folder was hardcoded, I've added a way to configure it into the configuration of the PHRets. By default it will be null.
not work if you pass a value (basic or digest) into the http_authentication. I've modify the code to be able to pass http_authentication = null when we set the config.
not work if you pass a value (basic or digest) into the http_authentication. I've modify the code to be able to pass http_authentication = null when we set the config.
SimpleXmlElement return an error when the content of the string is not valid UTF-8 chars. I've make sure the content is UTF-8. other chars get discarded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An old closed issue still valid and I've figured out the problem.
here is the issue I'm talking about: #73
WARNING:
The issue is releated to the fact some of the providers do not return the data properly and the xml is not valid.
1- the Windows/Linux issue is probably related to the ^M that appear at the end of each lines (Windows char). I've got this crap from the mlslistings rets server response.
2- I've also receive non UTF-8 char into the xml from the mlslisting server. ex: The copy right sigh that they didn't html entity.
I've test this fix with those rets servers: rebny, mlspin, gamls, fmls and mlslistings
You can test before applying the patch and after with this xml response string that came from the mlslistings rets where the sign ® cause the issue:
<RETS ReplyCode="0" ReplyText="Operation Successful"> <COUNT Records="1" /> <DELIMITER value="09" /> <COLUMNS> NRDSID PrimaryPhone AddressMailingCareOf OldOfficeID AddressMailingPostalCode AddressCityID AddressCareOf IDXYN Aggregation LongName MLS AddressLine1 CorporateLicense MasterOfficeID AddressMailingCounty Status FaxNumber NoOfBranches AddressMailing AddressStreetSuffix OfficeName VOW StateID DesignatedBroker AddressLine2 OtherPhone ContactMember OfficeID AddressMailingStateID AddressCityName BranchNumber Zip AddressStreetName BrokerCode AddressStateCode AddressMailingCityID Type MainOfficeID BrokerAgentID URL EmailAddress OldLastModDt BoardID LastModDt BranchType </COLUMNS> <DATA> 60842 (916) 929-4706 Roger Hackney, REALTOR® 877723528 95825 235 1 Quattro Roger Hackney MetroList 333 University Ave #200 00834701 877723528 Active (916) 929-6531 0 333 University Ave #200 Roger Hackney 5 44353 4592 5 1 95825 01RHCI 235 Real Estate Office / MLS 4592 44353 http://www.campuscommons.net roger@campuscommons.net 2018-07-09T15:22:45 MetroList 2018-07-09T15:28:44 Single/Standalone </DATA> <MAXROWS /> <RETS-STATUS ReplyCode="0" ReplyText="Operation Successful" /> </RETS>