New app: ground temperatures, displays soil temp, air temp, upcoming precipitation#423
New app: ground temperatures, displays soil temp, air temp, upcoming precipitation#423tavdog merged 2 commits intotronbyt:mainfrom
Conversation
…ing precipitation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new applet named "Ground Temperature," aimed at providing essential weather insights for lawn and gardening enthusiasts. The app displays current soil and air temperatures, alongside upcoming precipitation totals for the next 6, 12, and 24 hours. It intelligently sources weather data, prioritizing the National Weather Service (NWS) API for enhanced precipitation accuracy in the US, and defaulting to Open-Meteo for other regions or if NWS data is unavailable. Users can customize their location, preferred temperature units, and the specific soil depth for temperature readings. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new "Ground Temp" app that displays soil temperature, air temperature, and rainfall metrics. The review identified several areas for improvement: the rain_column function hardcodes the precipitation unit, which will lead to incorrect display for Celsius units, and includes an unnecessary explicit font setting. Additionally, unused constants and functions (DIGITS, get_daily_value, sum_days, format_rain) should be removed for code cleanliness. The manifest.yaml also contains a redundant and non-standard wide 2x support tag.
|
cool app ! |
No description provided.