Skip to content

New app: ground temperatures, displays soil temp, air temp, upcoming precipitation#423

Merged
tavdog merged 2 commits intotronbyt:mainfrom
ckelley-1992:main
Mar 26, 2026
Merged

New app: ground temperatures, displays soil temp, air temp, upcoming precipitation#423
tavdog merged 2 commits intotronbyt:mainfrom
ckelley-1992:main

Conversation

@ckelley-1992
Copy link
Contributor

No description provided.

@ckelley-1992 ckelley-1992 requested a review from tavdog as a code owner March 25, 2026 18:20
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new applet named "Ground Temperature," aimed at providing essential weather insights for lawn and gardening enthusiasts. The app displays current soil and air temperatures, alongside upcoming precipitation totals for the next 6, 12, and 24 hours. It intelligently sources weather data, prioritizing the National Weather Service (NWS) API for enhanced precipitation accuracy in the US, and defaulting to Open-Meteo for other regions or if NWS data is unavailable. Users can customize their location, preferred temperature units, and the specific soil depth for temperature readings.

Highlights

  • New Applet Introduction: Implemented a new 'Ground Temperature' applet designed to provide lawn-focused weather conditions.
  • Weather Data Integration: Integrated with the Open-Meteo API to fetch soil temperature, air temperature, and general precipitation data.
  • Enhanced Precipitation Accuracy: Added logic to fetch more accurate quantitative precipitation forecast (QPF) data for US locations from the National Weather Service (NWS) API, with Open-Meteo serving as a fallback.
  • User Configuration Options: Provided configurable options for users to set their location, preferred temperature units (Fahrenheit or Celsius), and desired soil depth (0cm, 6cm, or 18cm) for readings.
  • Display and UI: Designed a user interface to clearly display current soil and air temperatures, along with 6-hour, 12-hour, and 24-hour precipitation forecasts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new "Ground Temp" app that displays soil temperature, air temperature, and rainfall metrics. The review identified several areas for improvement: the rain_column function hardcodes the precipitation unit, which will lead to incorrect display for Celsius units, and includes an unnecessary explicit font setting. Additionally, unused constants and functions (DIGITS, get_daily_value, sum_days, format_rain) should be removed for code cleanliness. The manifest.yaml also contains a redundant and non-standard wide 2x support tag.

@tavdog tavdog merged commit bb96c3e into tronbyt:main Mar 26, 2026
1 check passed
@tavdog
Copy link
Member

tavdog commented Mar 26, 2026

cool app !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants