Conversation
Allure reports dependencies
Signed-off-by: AlexanderYenGEV <Alexander.Yen@gevernova.com>
To date changes to the forecasting features
|
Theres alot of files changed so sorry about that. For future PR, I will be keeping the changes to be alot smaller scaled so it is easier to review. But these are the main changes to the tests that I have been working on so far. |
caindy
left a comment
caindy
left a comment
There was a problem hiding this comment.
Let's get your other PR merged then rebase this. Please address the comments I've made so far, and I will circle back and review the rest.
| # PATCH Submit a Forecast Proposal | ||
| Scenario Outline: Submit a forecast proposal | ||
| Given the Content-type header is set to `<response_type>` | ||
| And the body is loaded from `<file_name>` |
There was a problem hiding this comment.
I'd suggest creating multiple scenarios and changing the language here to say
| And the body is loaded from `<file_name>` | |
| And the request body is a valid `<content_type>` for the authenticated Ratings Provider |
For now, we can implement the step definition to switch on <content_type> and load the appropriate file.
There was a problem hiding this comment.
Could you clarify on what you mean by multiple scenarios? Wouldn't submitting forecast proposal just encompass a singular scenario.
There was a problem hiding this comment.
Apologies, when I first started that comment I was thinking it would be cleaner to have a Submit slim forecast proposal, Submit standard forecast proposal, etc., but I thought better of it (it was late). I will edit my comment to remove "multiple scenarios".
Rebasing, resolved conflict in gitignore and conftest.py Rebasing, resolved conflict in gitignore and conftest.
Resolved 2nd conflic in gitignore and conftest.py for rebase
AlexanderYenGEV
force-pushed
the
forecasting-features
branch
from
a2875a9 to
e4e6618
Compare
Signed-off-by: AlexanderYenGEV <Alexander.Yen@gevernova.com>
3 participants
Added new scenarios to primarily snapshot_filters and snaphshot_formats.
Added a clearer terminal output for tests.