Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ func (c *Container) MustResolve(target interface{})
- **Exact Type Matching Only** - No interface binding support
- **Basic Named Dependencies** - No tags or name-based resolution
- **No Lifecycle Hooks** - Basic startup/shutdown only
- **No Error Handling** - Doesn't support ctor-s with error return
- **Limited ctor return types** - Only support ctors which returns pointers
- **Only types in ctor return** - Doesn't support interfaces as ctor return value
- **Only one return value** - one ctor = one value
Expand Down
32 changes: 12 additions & 20 deletions container.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
package compoapp

import (
"bufio"
"fmt"
"os"
"reflect"
"strings"
"sync"
)

Expand Down Expand Up @@ -449,9 +449,7 @@ func (c *Container) validateDependencies() error {
const dotHeader string = `digraph DependencyGraph {
rankdir=LR;
node [shape=box, style=rounded, fontname="Arial"];
edge [fontname="Arial"];

`
edge [fontname="Arial"];`

// Visualize creates .dot file for graphviz visualization
func (c *Container) Visualize(filepath string) error {
Expand All @@ -464,13 +462,11 @@ func (c *Container) Visualize(filepath string) error {
}
defer f.Close()

writer := bufio.NewWriter(f)
defer writer.Flush()
b := strings.Builder{}

// Write DOT header
if _, err := writer.WriteString(dotHeader); err != nil {
return fmt.Errorf("failed to write digraph header: %w", err)
}
b.WriteString(dotHeader)
b.WriteString("\n\n")

nodes := make(map[string]struct{})
edges := make(map[string][]string)
Expand Down Expand Up @@ -498,14 +494,10 @@ func (c *Container) Visualize(filepath string) error {
}

for nodeName := range nodes {
if _, err := fmt.Fprintf(writer, " %q;\n", nodeName); err != nil {
return fmt.Errorf("failed to write node name: %w", err)
}
b.WriteString(fmt.Sprintf(" %q;\n", nodeName))
}

if _, err := writer.WriteString("\n"); err != nil {
return fmt.Errorf("failed to write newline: %w", err)
}
b.WriteString("\n")

addedEdges := make(map[string]struct{})
for from, toList := range edges {
Expand All @@ -514,16 +506,16 @@ func (c *Container) Visualize(filepath string) error {
if _, exists := addedEdges[edgeKey]; exists {
continue
}
if _, err := fmt.Fprintf(writer, " %q -> %q;\n", from, to); err != nil {
return fmt.Errorf("failed to write edge: %w", err)
}
b.WriteString(fmt.Sprintf(" %q -> %q;\n", from, to))
addedEdges[edgeKey] = struct{}{}
}
}

// Close DOT graph
if _, err := writer.WriteString("}\n"); err != nil {
return fmt.Errorf("failed to write graph closure: %w", err)
b.WriteString("}\n")

if _, err := f.WriteString(b.String()); err != nil {
return fmt.Errorf("cannot write to dot file: %w", err)
}

return nil
Expand Down