[ADD] configure: odoo-config generation step on target host by dzungtran89 · Pull Request #43 · trobz/deploy.py

dzungtran89 · 2026-06-19T07:45:27Z

What

deploy configure now generates the Odoo config on the target host via odoo-config, instead of leaving config/odoo.conf to be written by hand.

New config step (odoo only), runs before unit. Mirrors the unit step: warns if the config exists, regenerates only when absent or --recreate (backs up to .bak first).
Generates via odoo-config create --version <v> -c config/server.conf <overrides>.
Default overrides: db_user, report.url, http_interface (= instance name); the deploy.yml config: block overrides them.
Version from the version: key, else prompts (default 19.0).
Tests + regenerated CLI reference doc.

Forge-ID: 68011

nilshamerlinck · 2026-06-19T09:45:33Z

+
+        if not conf_exists or recreate:
+            typer.secho(f"\n{CONFIGURE_STEPS['config']}…", fg="green")
+            version = opts.get("version") or typer.prompt("Target Odoo version", default="19.0")


can you run odoo-addons-path --verbose in project codebase to capture the detected odoo version instead of prompting it?

Please also consider the case that instance_path doesn't exist, for example, run with dry-run for non-existent instance_path.

nilshamerlinck · 2026-06-19T09:46:36Z

+            overrides: dict[str, Any] = {
+                "db_user": instance_name,
+                "report.url": f"http://{instance_name}:8069",
+                "http_interface": instance_name,


can you generate a strong admin_passwd by default to make sure we never have admin

nilshamerlinck · 2026-06-19T09:48:12Z

+                if conf_exists:
+                    executor.run(f"mv {conf_path} {conf_path}.bak", dry_run=dry_run)
+                executor.run(
+                    f"odoo-config create --version {shlex.quote(str(version))} -c {conf_path} {override_args}",


we should be abl to define --preset based on the instance name (e.g. staging)

hailangvn

Code review OK. LGTM. Thank you.

dzungtran89 · 2026-06-22T03:22:44Z

Thank you. The PR has been updated.

nilshamerlinck · 2026-06-22T03:34:00Z

 * `-p, --port INTEGER`: SSH port on the remote host.
 * `--repo-subdir TEXT`: Subdirectory within the repo to use as the service root (for monorepos).
 * `--repo-branch TEXT`: Git branch to clone and track (defaults to the repository&#x27;s default branch).
+* `--recreate / --no-recreate`: Re-create venv in case it exists. This is useful when you want to update the venv.  \[default: no-recreate\]


not only venv: also unit, config

Thank you. The PR has been updated to address this comment and another one.

nilshamerlinck · 2026-06-22T03:37:15Z

+    # before the command runs); the remote executor degrades to a non-zero ExecutorError.
+    try:
+        detected = executor.capture(
+            "odoo-addons-path --verbose | awk -F': ' '/^Odoo version:/ {print $2; exit}'",


fyi we also have --format json

btw, I think it would be worth if odoo-addons-path could detect the odoo edition: CE or EE (with a naive low io heuristic such as having the addons directory "enterprise" or "odoo-enterprise")
because some elements of the config will differ, e.g. database.expiration* in integration/staging environments
could you please create a PR on odoo-addons-path for that?

btw, I think it would be worth if odoo-addons-path could detect the odoo edition: CE or EE (with a naive low io heuristic such as having the addons directory "enterprise" or "odoo-enterprise") because some elements of the config will differ, e.g. database.expiration* in integration/staging environments could you please create a PR on odoo-addons-path for that?

Hello Nils,

About this request, could you please confirm the scope below?

Add a get_odoo_edition() heuristic: returns EE if a resolved addons path is
named enterprise/odoo-enterprise, otherwise CE.

Expose it as odoo_edition (values CE/EE) in the JSON output, plus an Odoo
edition: line in the verbose text.

Thanks!

New "config" step in `deploy configure` (odoo only): generate config/odoo.conf by running odoo-config on the target host, mirroring the "unit" step (warn if it exists, regenerate on --recreate after backing up to .bak). Defaults passed as overrides: db_user, report.url, http_interface; the deploy.yml `config:` block overrides them. Target Odoo version comes from the `version:` key, else prompts (default 19.0). Forge-ID: 68011

hailangvn · 2026-06-22T04:19:21Z

                "db_user": instance_name,
                "report.url": f"http://{instance_name}:8069",
                "http_interface": instance_name,
+                "admin_passwd": secrets.token_urlsafe(24),


Should we add a warning for user to change password to not surprise the person about this setting?

let's discuss about it on the private side: https://gitlab.trobz.com/packages/deploy.py-tms/-/issues/1

- Derive odoo-config --preset from the dash-separated instance type (production/staging/integration); demo/hotfix/test/training get none. Override via the deploy.yml `preset:` key. - Detect the Odoo version from `odoo-addons-path --verbose` in the codebase instead of prompting; prompt only as a fallback. - Generate a strong admin_passwd by default so the config never ships `admin`. Forge-ID: 68011

Surface the Odoo edition in `--format json` (new `odoo_edition` key) and in the `--verbose` text output. Inferred name-based from the resolved addons_path: EE when an `enterprise`/`odoo-enterprise` dir is present, otherwise CE, and None when no addons resolve. Follow-up of trobz/deploy.py#43 (comment) Forge-ID: 68011

dzungtran89 force-pushed the feat/configure-odoo-config branch 3 times, most recently from 20fd2bf to 9b367fe Compare June 19, 2026 07:52

dzungtran89 requested a review from nilshamerlinck June 19, 2026 08:02

nilshamerlinck requested changes Jun 19, 2026

View reviewed changes

nilshamerlinck assigned hailangvn Jun 19, 2026

dzungtran89 marked this pull request as draft June 19, 2026 09:52

hailangvn reviewed Jun 22, 2026

View reviewed changes

dzungtran89 marked this pull request as ready for review June 22, 2026 03:22

nilshamerlinck requested changes Jun 22, 2026

View reviewed changes

hailangvn reviewed Jun 22, 2026

View reviewed changes

This was referenced Jun 22, 2026

[ADD] cli: detect Odoo edition (CE/EE) and expose odoo_edition dzungtran89/odoo-addons-path#1

Closed

[ADD] cli: detect Odoo edition (CE/EE) and expose odoo_edition trobz/odoo-addons-path#17

Merged

dzungtran89 force-pushed the feat/configure-odoo-config branch from 4c841d5 to 32e1ce6 Compare June 22, 2026 05:20

dzungtran89 force-pushed the feat/configure-odoo-config branch from 32e1ce6 to b34b3d2 Compare June 22, 2026 05:21

nilshamerlinck merged commit 214329e into trobz:main Jun 22, 2026
7 checks passed

Uh oh!

Conversation

dzungtran89 commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Contents

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hailangvn left a comment

Choose a reason for hiding this comment

Uh oh!

dzungtran89 commented Jun 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dzungtran89 commented Jun 19, 2026 •

edited

Loading