Skip to content

More fixes for rigid bodies#1110

Merged
svchb merged 12 commits intotrixi-framework:mainfrom
svchb:rigid_fixes
Mar 25, 2026
Merged

More fixes for rigid bodies#1110
svchb merged 12 commits intotrixi-framework:mainfrom
svchb:rigid_fixes

Conversation

@svchb
Copy link
Copy Markdown
Collaborator

@svchb svchb commented Mar 19, 2026

The changes to compact_support and apply_state_equation are only needed if we want to reuse the wall boundaries for pure rigid interactions. Alternatively we can throw an error which might be the better solution?

@svchb svchb added the bug Something isn't working label Mar 19, 2026
@svchb svchb self-assigned this Mar 19, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.53%. Comparing base (a0871ca) to head (3aaecfa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1110      +/-   ##
==========================================
+ Coverage   89.46%   89.53%   +0.06%     
==========================================
  Files         126      126              
  Lines        9657     9663       +6     
==========================================
+ Hits         8640     8652      +12     
+ Misses       1017     1011       -6     
Flag Coverage Δ
total 89.53% <100.00%> (+0.06%) ⬆️
unit 67.51% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/schemes/boundary/wall_boundary/dummy_particles.jl Outdated
svchb and others added 2 commits March 24, 2026 14:30
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
@svchb svchb requested a review from efaulhaber March 24, 2026 13:30
efaulhaber
efaulhaber previously approved these changes Mar 25, 2026
@svchb svchb requested a review from efaulhaber March 25, 2026 12:25
@svchb svchb enabled auto-merge (squash) March 25, 2026 12:26
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 25, 2026

/run-gpu-tests

efaulhaber
efaulhaber previously approved these changes Mar 25, 2026
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 25, 2026

/run-gpu-tests

@svchb svchb merged commit 55951e4 into trixi-framework:main Mar 25, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants