More fixes for rigid bodies#1110
Merged
svchb merged 12 commits intotrixi-framework:mainfrom Mar 25, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
+ Coverage 89.46% 89.53% +0.06%
==========================================
Files 126 126
Lines 9657 9663 +6
==========================================
+ Hits 8640 8652 +12
+ Misses 1017 1011 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efaulhaber
requested changes
Mar 24, 2026
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
efaulhaber
previously approved these changes
Mar 25, 2026
Collaborator
Author
|
/run-gpu-tests |
efaulhaber
previously approved these changes
Mar 25, 2026
Collaborator
Author
|
/run-gpu-tests |
efaulhaber
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes to compact_support and apply_state_equation are only needed if we want to reuse the wall boundaries for pure rigid interactions. Alternatively we can throw an error which might be the better solution?