Merged
Conversation
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 16 16
Lines 489 489
=======================================
Hits 432 432
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
efaulhaber
force-pushed
the
ef/benchmarks2
branch
from
8230ddc to
94fe348
Compare
svchb
requested changes
Jun 26, 2024
Collaborator
svchb
left a comment
svchb
left a comment
There was a problem hiding this comment.
This should be included in the benchmark testsuite?
Also do you want to add a file to actually run a benchmark?
Member
Author
|
Thanks! Forgot to add it to the tests. |
…hborhoodSearch.jl into ef/benchmarks2
Member
Author
|
Depends on trixi-framework/TrixiParticles.jl#580. |
svchb
previously approved these changes
Aug 5, 2024
Collaborator
|
@efaulhaber The tests still fail. |
Member
Author
|
Yes, waiting for the next release of TrixiParticles. |
Member
Author
|
The errors are fixed by trixi-framework/TrixiParticles.jl#580. |
…hborhoodSearch.jl into ef/benchmarks2
svchb
approved these changes
Aug 7, 2024
LasNikas
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on trixi-framework/TrixiParticles.jl#550.