feature/extract-idm-scripts: Support exporting and importing idm scri…#73
feature/extract-idm-scripts: Support exporting and importing idm scri…#73skootrivir wants to merge 1 commit into
Conversation
phalestrivir
force-pushed
the
feature/extract-idm-script-rework
branch
from
a84abfa to
8d63829
Compare
|
|
||
| const parsed = JSON.parse(fileData); | ||
| const allEntities = Object.entries(parsed.idm) | ||
| .filter(([id]) => id !== 'meta') // ✅ "meta" 필터링 |
There was a problem hiding this comment.
Was this generated by ChatGPT? We don't need the comment there. Also, if you are just trying to filter out the Frodo metadata, it will never be in the idm object, it should look like this if metadata is there (so I don't even think you need to filter it):
{ idm: { ... }, meta: { ... } }
| } | ||
|
|
||
| /** | ||
| * Import all IDM configuration objects from working directory |
There was a problem hiding this comment.
I don't think we need this change, it should stay all caps
| "endpoint/oauthproxy": { | ||
| "_id": "endpoint/oauthproxy", | ||
| "context": "endpoint/oauthproxy", | ||
| "file": "oauthProxy.js", |
There was a problem hiding this comment.
Some of these endpoints are wrong (they shouldn't have a file parameter, just the source parameter)
There was a problem hiding this comment.
We've talked about this, but this is ForgeOps' default endpoints that don't exist.
| "endpoint/mappingDetails": { | ||
| "_id": "endpoint/mappingDetails", | ||
| "context": "endpoint/mappingDetails", | ||
| "file": "mappingDetails.js", |
There was a problem hiding this comment.
Some of these endpoints are wrong (they shouldn't have a file parameter, just the source parameter)
| "enabled": true, | ||
| "from": "", | ||
| "html": { | ||
| "en": "<html><body><p>Welcome to OpenIDM. Your username is '{{object.userName}}'.</p></body></html>" |
There was a problem hiding this comment.
I think we should export the HTML and CSS data into separate files like config-manager does
There was a problem hiding this comment.
I think instead of naming the directory ".managed.scripts", it should just be called "", since if you are extracting with -x then it's obvious that the directory of the corresponding object name has the scripts inside of it. The way it is currently named, it looks like a file and not a directory.
There was a problem hiding this comment.
The name of the file is taskscan_activate.invokeContext.tasks.script.script.js, I think it should be taskscan_activate.idm.js, since there should only ever be one script associated with a schedule
phalestrivir
force-pushed
the
feature/extract-idm-script-rework
branch
from
6904cb3 to
b5d8436
Compare
|
I just rebased and squashed everything. I also made some fixes to the code, include updating Tests are still not passing, I didn't get to updating those yet. If nobody gets to it before I'm back from out of town I can get the rest finished. |
2 participants
…pts from global/idm including mappings(sync) and managed objects schema config.