Allow thread in grpc _InferStream be daemon#867
Open
pavelkochnev wants to merge 2 commits intotriton-inference-server:mainfrom
Open
Allow thread in grpc _InferStream be daemon#867pavelkochnev wants to merge 2 commits intotriton-inference-server:mainfrom
pavelkochnev wants to merge 2 commits intotriton-inference-server:mainfrom
Conversation
Author
|
@matthewkotila Could you review this PR, pls? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases user can call
tritonclient.grpc.InferenceServerClient.start_stream()but forget to calltritonclient.grpc.InferenceServerClient.stop_stream()later.start_streamcreated_InferStreamobject which internal also createsthreading.Thread()instance. Because thread is not daemonic, the main process never stoped, ifstop_stream()never called.This PR allow user make internal thread daemonic, so main process can exit even if
stop_stream()never called.