Open
Conversation
wendigo
commented
Mar 26, 2026
| python3 Tools/wasm/wasi.py make-host | ||
| make -C cross-build/wasm32-wasi install COMPILEALL_OPTS='-j0 -b' | ||
| python3 Tools/wasm/wasi configure-host -- \ | ||
| CFLAGS='-Os -mtail-call' --prefix=${PYTHON_PATH} --disable-test-modules --with-tail-call-interp |
Contributor
Author
There was a problem hiding this comment.
This makes the python_eval_frame smaller for chicory to compile
Contributor
Author
|
electrum
approved these changes
Mar 26, 2026
| find . -name '*.dist-info' -exec rm -rf {} \; | ||
| rm -rf bin | ||
| /build/cpython/cross-build/build/python -m compileall -b . | ||
| $(find /build/cpython/cross-build -maxdepth 2 -name python -not -path '*/wasm32-*' -type f) -m compileall -b . |
Member
There was a problem hiding this comment.
This seems suspicious. It would be better to invoke this directly with the exact path.
| JSON = 20, | ||
| UUID = 21, | ||
| IPADDRESS = 22, | ||
| NUMBER = 23, |
Member
There was a problem hiding this comment.
Do we actually need to treat this as a separate type, if we're handling it identically to decimal on the Python side?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.