change lineitem.quantity from integer to double#13
Open
ilfrin wants to merge 1 commit intotrinodb:masterfrom
Open
change lineitem.quantity from integer to double#13ilfrin wants to merge 1 commit intotrinodb:masterfrom
ilfrin wants to merge 1 commit intotrinodb:masterfrom
Conversation
This change is required to conform to the TPC-H spec. The 2.17.1 version states that the lineitem.l_quantity field should be of decimal type (page 17), as opposed to the currently implemented integer.
Member
|
IIRC, quantity is always a whole number so BIGINT is more appropriate until DECIMAL lands in Presto. |
Member
Author
|
We can look at this as you say. Then again my original intent was for the schema to conform to the spec. I understand that the generator produces only integers, but quantity in theory may be a fraction as well, which I believe was the intent of the spec. I don't feel strongly either way, so we can land this after decimal lands in Presto, of you prefer that. Then again, this being a separate airlift project was about abstracting from Presto, so why should we connect that this way :) This isn't a show stopper, so we can wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is required to conform to the TPC-H spec. The 2.17.1 version
states that the lineitem.l_quantity field should be of decimal type (page
17), as opposed to the currently implemented integer.
I came across this when testing Presto with decimal on TPC-H queries and checking the results.
Not sure if I changed all the necessary bits.
cc @dain