Resolve github action warning messages before they break#148
Open
808sAndBR wants to merge 7 commits intotrilom:masterfrom
Open
Resolve github action warning messages before they break#148808sAndBR wants to merge 7 commits intotrilom:masterfrom
808sAndBR wants to merge 7 commits intotrilom:masterfrom
Conversation
Fix gh action warning
Fix gh action warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Resolves
Describe Changes
Github has deprecated the
set-outputcommand and it will be disabled soon.https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
This action is doing its output setting this way via the
@actions/corepackage it is importing. By upgrading the version from1.2.3to1.10.0and recompiling we seem to be able to avoid this without any further work needed.I tried to follow the compilation commands as well as I could guess through them based on the .github/ action files but my minimized file seems to be multi line instead of one but seems to work regardless. I am new to typescript but happy to rerun the build different if preferred to get this PR merged (just tell me what to do). It does seem to work fine as is though.
Note: If this package has more active development done in the future, this should also be updated in its own
.github/directory. I would be happy to help with this if someone wants to do more active dev work in the future.