Open
Conversation
|
Thanks for opening this PR, |
Author
|
Hi @trilom just noticed this still open and wanted to check if there is anything useful I can do on my end. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Resolves
files#108Describe Changes
This will add clarity about the availability of files_renamed which I believe is causing the confusion people have voiced in #108 where it is not actually a bug, but just that it is not clear that this data is available. As far as I can tell (I don't actually know js/ts) the renamed files are getting added/processed here:
file-changes-action/src/FilesHelper.ts
Lines 24 to 30 in a6ca26c