fix: Using platform-agnostic homedir() as output dir#124
Open
james-braund wants to merge 1 commit intotrilom:masterfrom
Open
fix: Using platform-agnostic homedir() as output dir#124james-braund wants to merge 1 commit intotrilom:masterfrom
homedir() as output dir#124james-braund wants to merge 1 commit intotrilom:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Resolves
Describe Changes
Switched out platform-specific
process.env.HOMEfor platform agnosticos.homedir().Haven't adjusted unit tests, as they still feel appropriate. You could make the argument that we should mock the response from
os.homedir()instead of allowing a real call to the underlay environment variables, but that would require some fairly significant refactoring of the tests.