Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/webapp/app/components/primitives/Resizable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ const ResizablePanelGroup = ({ className, ...props }: React.ComponentProps<typeo
"flex w-full overflow-hidden data-[panel-group-direction=vertical]:flex-col",
className
)}
autosaveStrategy={props.autosaveId ? "cookie" : undefined}
{...props}
/>
);
Comment on lines 10 to 15
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Fix effectiveness depends on library default for autosaveStrategy

The PR removes the explicit autosaveStrategy={props.autosaveId ? "cookie" : undefined} prop, but callers still pass autosaveId to ResizablePanelGroup (e.g., apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx:511, :587, :780, and apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.prompts.$promptSlug/route.tsx:589, :596, :1439). If react-window-splitter@0.4.1 defaults autosaveStrategy to "cookie" when autosaveId is provided, the removal would be a no-op and cookies would still be written, meaning the HTTP 431 errors would persist. The library's actual default should be verified to confirm this fix is effective.

(Refers to lines 7-15)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Expand Down
Loading