-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(webapp): runs not appearing in local development #2599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
LeoKaynan
wants to merge
4
commits into
triggerdotdev:main
from
LeoKaynan:fix(dashboard)-runs-not-appearing-in-local-development
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
22ffbe2
fix(webapp): runs not appearing in local development
LeoKaynan 2465678
test(webapp): add unit tests for runsRepositoryFactory
LeoKaynan e362f07
refactor(webapp): enhance runsRepositoryFactory to accept options forβ¦
LeoKaynan 6244106
refactor(webapp): replace runsRepositoryFactory with direct RunsReposβ¦
LeoKaynan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import type { ClickHouse } from "@internal/clickhouse"; | ||
| import type { PrismaClient } from "@trigger.dev/database"; | ||
| import { env } from "~/env.server"; | ||
| import { RunsRepository } from "./runsRepository/runsRepository.server"; | ||
|
|
||
| export function createRunsRepository(options: { | ||
| clickhouse: ClickHouse; | ||
| prisma: PrismaClient; | ||
| }): RunsRepository { | ||
| const isReplicationEnabled = env.RUN_REPLICATION_ENABLED === "1"; | ||
| const isClickHouseConfigured = !!env.RUN_REPLICATION_CLICKHOUSE_URL; | ||
|
|
||
| const defaultRepository = isReplicationEnabled && isClickHouseConfigured | ||
| ? "clickhouse" | ||
| : "postgres"; | ||
|
|
||
| return new RunsRepository({ | ||
| ...options, | ||
| defaultRepository, | ||
| }); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"; | ||
| vi.mock("~/env.server", () => ({ | ||
| env: {}, | ||
| })); | ||
| vi.mock("~/db.server", () => ({ | ||
| prisma: {}, | ||
| $replica: {}, | ||
| })); | ||
|
|
||
| import { createRunsRepository } from "~/services/runsRepositoryFactory.server"; | ||
| import type { ClickHouse } from "@internal/clickhouse"; | ||
| import type { PrismaClient } from "@trigger.dev/database"; | ||
|
|
||
| describe("createRunsRepository", () => { | ||
| let mockClickhouse: ClickHouse; | ||
| let mockPrisma: PrismaClient; | ||
| let originalEnv: Record<string, unknown>; | ||
|
|
||
| beforeEach(async () => { | ||
| const envModule = await import("~/env.server"); | ||
| originalEnv = { ...envModule.env }; | ||
|
|
||
| mockClickhouse = {} as ClickHouse; | ||
| mockPrisma = {} as PrismaClient; | ||
| }); | ||
|
|
||
| afterEach(async () => { | ||
| const envModule = await import("~/env.server"); | ||
| Object.assign(envModule.env, originalEnv); | ||
| }); | ||
|
|
||
| it("should default to postgres when RUN_REPLICATION_ENABLED is not set", async () => { | ||
| const envModule = await import("~/env.server"); | ||
| envModule.env.RUN_REPLICATION_ENABLED = "0"; | ||
| envModule.env.RUN_REPLICATION_CLICKHOUSE_URL = "http://localhost:8123"; | ||
|
|
||
| const repository = createRunsRepository({ | ||
| clickhouse: mockClickhouse, | ||
| prisma: mockPrisma, | ||
| }); | ||
|
|
||
| expect(repository).toBeDefined(); | ||
| expect(repository.listRuns).toBeDefined(); | ||
| }); | ||
|
|
||
| it("should default to postgres when RUN_REPLICATION_CLICKHOUSE_URL is not set", async () => { | ||
| const envModule = await import("~/env.server"); | ||
| envModule.env.RUN_REPLICATION_ENABLED = "1"; | ||
| envModule.env.RUN_REPLICATION_CLICKHOUSE_URL = undefined; | ||
|
|
||
| const repository = createRunsRepository({ | ||
| clickhouse: mockClickhouse, | ||
| prisma: mockPrisma, | ||
| }); | ||
|
|
||
| expect(repository).toBeDefined(); | ||
| expect(repository.listRuns).toBeDefined(); | ||
| }); | ||
|
|
||
| it("should default to clickhouse when both conditions are met", async () => { | ||
| const envModule = await import("~/env.server"); | ||
| envModule.env.RUN_REPLICATION_ENABLED = "1"; | ||
| envModule.env.RUN_REPLICATION_CLICKHOUSE_URL = "http://localhost:8123"; | ||
|
|
||
| const repository = createRunsRepository({ | ||
| clickhouse: mockClickhouse, | ||
| prisma: mockPrisma, | ||
| }); | ||
|
|
||
| expect(repository).toBeDefined(); | ||
| expect(repository.listRuns).toBeDefined(); | ||
| }); | ||
|
|
||
| it("should create a valid RunsRepository instance", () => { | ||
| const repository = createRunsRepository({ | ||
| clickhouse: mockClickhouse, | ||
| prisma: mockPrisma, | ||
| }); | ||
|
|
||
| expect(repository.listRuns).toBeDefined(); | ||
| expect(repository.countRuns).toBeDefined(); | ||
| expect(typeof repository.listRuns).toBe("function"); | ||
| expect(typeof repository.countRuns).toBe("function"); | ||
| }); | ||
| }); | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.