Remove ecdsa dependency, use cryptography only II #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onvej-sl
commented
Dec 19, 2025
Comment on lines
+133
to
+138
| if self.curve.name == "secp256k1": | ||
| p = 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFEFFFFFC2F | ||
| elif self.curve.name == "secp256r1": | ||
| p = 0xFFFFFFFF00000001000000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF | ||
| else: | ||
| raise NotImplementedError(f"Curve {self.curve.name} is not supported") |
Collaborator
Author
There was a problem hiding this comment.
Since the implementation of elliptic curves in the cryptography package is only a wrapper over openssl, the package doesn't even export the curves' moduli.
| ecdsa = "*" | ||
| python = ">=3.8,<4.0" | ||
| cryptography = ">=45" | ||
| python = ">3.9.0,<3.9.1 || >3.9.1,<3.14.0" |
Collaborator
There was a problem hiding this comment.
- ISTM that
>3.9.0,<3.9.1is not satisfiable, so only the latter condition makes sense. Or am I misunderstanding the syntax? - Curious, why is 3.14 excluded?
- Let's update
.github/workflows/python-package.ymlaccordingly.
Collaborator
Author
There was a problem hiding this comment.
- ISTM that >3.9.0,<3.9.1 is not satisfiable, so only the latter condition makes sense. Or am I misunderstanding the syntax?
- Curious, why is 3.14 excluded?
I don't consider this to be the final solution. I only did what poetry advised me to do in order to upgrade the cryptography package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #2. Unlike that, I've tried to use the cryptography package as much as possible.