Skip to content

Update from upstream #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewkozlik merged 2 commits into from
Dec 17, 2025
Merged

Update from upstream #3

andrewkozlik merged 2 commits into from
Dec 17, 2025

Conversation

@andrewkozlik
Copy link
Collaborator

@andrewkozlik andrewkozlik commented Dec 17, 2025

  • Drop base58 dependency. Port base58 code directly in-tree as a base58 module.
  • Add a new method get_fingerprint().

darosior and others added 2 commits December 17, 2025 11:58
@darosior @andrewkozlik
Drop base58 dependency, copy over David Keijser's code directly
d8bb174 
There is no need to be remotely fetching code for a simple 100 lines
file of code which should never change anymore.
@andrewkozlik
Expose get_fingerprint() method to SLIP10
c53f346 
Cherry-picked a50678c and 43a0352 from upstream.
@andrewkozlik andrewkozlik mentioned this pull request Dec 17, 2025
Closed
matejcik
matejcik approved these changes Dec 17, 2025
View reviewed changes
Copy link
Collaborator

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@andrewkozlik andrewkozlik merged commit 9fb8c2e into master Dec 17, 2025
2 of 8 checks passed
@andrewkozlik andrewkozlik deleted the update-from-upstream branch December 17, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejcik matejcik matejcik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewkozlik @matejcik @darosior