fix overflow problem#1298
Open
sriharivishnu wants to merge 4 commits intomasterfrom
Open
Conversation
rrijal53
previously approved these changes
Aug 7, 2020
dogi
force-pushed
the
master
branch
2 times, most recently
from
5c640ca to
7f9f670
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching from a long running task that has not terminated, there are often errors when the output from the last command are carried over to a new fragment.
Example : ServicesFragment (
treehouses remote allservices) -> StatusFragment#734 uses delimiters to find when a command has started and ended, and keeps a queue of commands in progress.
This PR solves the issue by killing all running commands by sending a special command to the bluetooth server when switching fragments (Specifically, called in the OnDestroyView of BaseFragment).
Bluetooth branch required:
should work; otherwise, manually copy server.py into /usr/local/bin/bluetooth-server.py