Skip to content

Fix JavaScript indexed accessors#85

Merged
treeform merged 1 commit into
masterfrom
fix-js-accessors
May 25, 2026
Merged

Fix JavaScript indexed accessors#85
treeform merged 1 commit into
masterfrom
fix-js-accessors

Conversation

@treeform
Copy link
Copy Markdown
Owner

@treeform treeform commented May 25, 2026

Summary

  • Use JS-safe indexed accessors for object-backed vectors and matrices.
  • Use direct nested array assignment for array-backed matrices when compiling to JavaScript.
  • Add indexed accessor coverage across vector scalar types and float matrix types, plus CI rows for JS object/array storage modes.

Testing

  • git diff --check
  • nim r tests/tests.nim
  • nim r -d:vmathObjBased tests/tests.nim
  • nim r -d:vmathArrayBased tests/tests.nim
  • nim js -r tests/tests.nim
  • nim js -r -d:vmathObjBased tests/tests.nim
  • nim js -r -d:vmathArrayBased tests/tests.nim

@treeform treeform marked this pull request as ready for review May 25, 2026 18:53
@treeform treeform force-pushed the fix-js-accessors branch from eb03182 to 1016f61 Compare May 25, 2026 18:56
@treeform treeform merged commit 4c7fcd1 into master May 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant