π‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Auth Management Handlers#133
π‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Auth Management Handlers#133
Conversation
Update query parsing to enforce cross-platform path traversal prevention using strings.ContainsAny(name, "/\\") instead of relying purely on os.PathSeparator. Add mock-backed security tests. Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Path Traversal via
namequery parameter inUploadAuthFileandDeleteAuthFile.π― Impact: An attacker could potentially upload an auth file outside the
authsdirectory or delete arbitrary files on the system ifswitchAILocalis running on Linux but targeted with a Windows-style path payload (\).π§ Fix: Changed the path traversal check to use
strings.ContainsAny(name, "/\\")explicitly instead ofos.PathSeparator.β Verification: Verify using
go test ./internal/api/handlers/management -run TestUploadAuthFile_PathTraversalandTestDeleteAuthFile_PathTraversal.Reused a mock
coreauth.Storeimplementation to simulate auth manager environments effectively during tests, improving their reliability.PR created automatically by Jules for task 10945029822529610499 started by @rschumann