Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Auth Management Handlers#133

Closed
rschumann wants to merge 1 commit intomainfrom
sentinel-fix-auth-file-path-traversal-10945029822529610499
Closed

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Auth Management Handlers#133
rschumann wants to merge 1 commit intomainfrom
sentinel-fix-auth-file-path-traversal-10945029822529610499

Conversation

@rschumann
Copy link
Copy Markdown
Contributor

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Path Traversal via name query parameter in UploadAuthFile and DeleteAuthFile.
🎯 Impact: An attacker could potentially upload an auth file outside the auths directory or delete arbitrary files on the system if switchAILocal is running on Linux but targeted with a Windows-style path payload (\).
πŸ”§ Fix: Changed the path traversal check to use strings.ContainsAny(name, "/\\") explicitly instead of os.PathSeparator.
βœ… Verification: Verify using go test ./internal/api/handlers/management -run TestUploadAuthFile_PathTraversal and TestDeleteAuthFile_PathTraversal.

Reused a mock coreauth.Store implementation to simulate auth manager environments effectively during tests, improving their reliability.


PR created automatically by Jules for task 10945029822529610499 started by @rschumann

Update query parsing to enforce cross-platform path traversal prevention using strings.ContainsAny(name, "/\\") instead of relying purely on os.PathSeparator.
Add mock-backed security tests.

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@rschumann rschumann closed this Apr 8, 2026
@rschumann rschumann deleted the sentinel-fix-auth-file-path-traversal-10945029822529610499 branch April 8, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant