🛡️ Sentinel: [HIGH] Fix path traversal in auth_files handlers#131
🛡️ Sentinel: [HIGH] Fix path traversal in auth_files handlers#131
Conversation
In `internal/api/handlers/management/auth_files.go`, `UploadAuthFile` and `DeleteAuthFile` previously checked for path traversals using `os.PathSeparator`. This behaves as `\` on Windows, leaving `../` payloads unchecked on Windows environments. Updated both occurrences to use `strings.ContainsAny(name, "/\\")` according to the Sentinel Security Pattern to consistently protect against cross-platform directory traversal on all underlying environments. Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
rschumann
deleted the
sentinel-fix-auth-file-path-traversal-9010333582127816163
branch
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Path Traversal via OS-specific path separators.
UploadAuthFileandDeleteAuthFilechecked for invalid file paths usingos.PathSeparator. On Windows systems, this translates only to\, allowing an attacker to bypass validation using/(e.g.,../../sensitive.json) to write or delete unauthorized files.🎯 Impact: An attacker could potentially upload an auth file to a directory outside of
cfg.AuthDiror delete an arbitrary system file the server had write permissions for, leading to Denial of Service (DoS) or unauthorized persistence.🔧 Fix: Replaced the
strings.Contains(name, string(os.PathSeparator))with the cross-platform Sentinel standardstrings.ContainsAny(name, "/\\"). This explicitly validates and blocks both standard/and Windows\separators on all environments.✅ Verification: Ran the test suite
go test ./... -shortand specific path traversal integration tests inTestDownloadAuthFile_PathTraversalinsideinternal/api/handlers/management(which passed). Checked the resulting Go code and it matches exactly the recommended prevention patterns.PR created automatically by Jules for task 9010333582127816163 started by @rschumann