π‘οΈ Sentinel: [HIGH] Fix path traversal in auth files handlers#110
π‘οΈ Sentinel: [HIGH] Fix path traversal in auth files handlers#110
Conversation
Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: Path traversal vulnerability in
UploadAuthFileandDeleteAuthFilewhere thenameparameter orfile.Filenamewas validated using only the OS path separator (e.g.,os.PathSeparator), which allows cross-platform path traversal if a client sends a Windows-style separator (\) to a Linux server, or vice versa.π― Impact: An attacker could potentially write or delete arbitrary files outside the configured
AuthDirdirectory if the application is running in an environment where the differing path separator is interpreted as a directory traversal payload by the filesystem or downstream processes.π§ Fix: Replaced the OS-specific validation
strings.Contains(name, string(os.PathSeparator))with cross-platform validationstrings.ContainsAny(name, "/\\")for both uploaded file names and thenamequery parameter in theUploadAuthFileandDeleteAuthFilehandlers. Also explicitly validate thefile.Filenameparsed from the form data before evaluatingfilepath.Base(). Added missing unit tests forUploadAuthFileandDeleteAuthFilesecurity paths inauth_files_security_test.go.β Verification: Verified by running
go test ./internal/api/handlers/management -run "TestUploadAuthFile_PathTraversal|TestDeleteAuthFile_PathTraversal"successfully.PR created automatically by Jules for task 15061360802444008909 started by @rschumann