Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix path traversal in auth files handlers#110

Closed
rschumann wants to merge 2 commits intomainfrom
sentinel/fix-path-traversal-auth-files-15061360802444008909
Closed

πŸ›‘οΈ Sentinel: [HIGH] Fix path traversal in auth files handlers#110
rschumann wants to merge 2 commits intomainfrom
sentinel/fix-path-traversal-auth-files-15061360802444008909

Conversation

@rschumann
Copy link
Copy Markdown
Contributor

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Path traversal vulnerability in UploadAuthFile and DeleteAuthFile where the name parameter or file.Filename was validated using only the OS path separator (e.g., os.PathSeparator), which allows cross-platform path traversal if a client sends a Windows-style separator (\) to a Linux server, or vice versa.
🎯 Impact: An attacker could potentially write or delete arbitrary files outside the configured AuthDir directory if the application is running in an environment where the differing path separator is interpreted as a directory traversal payload by the filesystem or downstream processes.
πŸ”§ Fix: Replaced the OS-specific validation strings.Contains(name, string(os.PathSeparator)) with cross-platform validation strings.ContainsAny(name, "/\\") for both uploaded file names and the name query parameter in the UploadAuthFile and DeleteAuthFile handlers. Also explicitly validate the file.Filename parsed from the form data before evaluating filepath.Base(). Added missing unit tests for UploadAuthFile and DeleteAuthFile security paths in auth_files_security_test.go.
βœ… Verification: Verified by running go test ./internal/api/handlers/management -run "TestUploadAuthFile_PathTraversal|TestDeleteAuthFile_PathTraversal" successfully.


PR created automatically by Jules for task 15061360802444008909 started by @rschumann

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
@rschumann rschumann closed this Apr 8, 2026
@rschumann rschumann deleted the sentinel/fix-path-traversal-auth-files-15061360802444008909 branch April 8, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant