Change relay arg from block number to block rlp#9
Open
k06a wants to merge 1 commit intotranvictor:masterfrom
Open
Change relay arg from block number to block rlp#9k06a wants to merge 1 commit intotranvictor:masterfrom
k06a wants to merge 1 commit intotranvictor:masterfrom
Conversation
tranvictor
reviewed
Feb 17, 2020
Owner
tranvictor
left a comment
There was a problem hiding this comment.
Working with the block itself instead of the block number is a good idea, however, I think we better make another command line for that instead of changing this one.
Owner
|
@k06a can you take a look at my comment and change accordingly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to use with any network. We serialise web3js header to rlp with this code: