Conversation
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Code Review SummaryThis pull request introduces significant improvements in internationalization (i18n) across several key components and the 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| // 2. Add a new object to this 'languages' array below. | ||
| // 3. Copy the corresponding SVG file from 'node_modules/country-flag-icons/3x2/' | ||
| // to the 'public/flags/' directory. | ||
| // Example command: cp node_modules/country-flag-icons/3x2/US.svg public/flags/us.svg | ||
| const languages = ref([ | ||
| { code: 'GB', name: 'English', flagUrl: '/flags/gb.svg' }, | ||
| { code: 'FR', name: 'French', flagUrl: '/flags/fr.svg' }, |
There was a problem hiding this comment.
These comments are no longer relevant as the language array is now dynamically generated from locales.value and languageInfo. Removing them will keep the code clean and prevent confusion.
| { label: 'All time', value: 'all_time', days: 0 }, | ||
| { label: 'This week', value: 'current_week', days: 0 }, | ||
| { label: 'This month', value: 'current_month', days: 0 }, | ||
| { label: 'Last 3 months', value: '90d', days: 90 }, | ||
| { label: 'Custom', value: 'custom', days: 0 } |
There was a problem hiding this comment.
The AVAILABLE_PERIODS array has been updated in the diff to only include thisWeek, thisMonth, and thisYear. The entries for 'All time', 'Last 3 months', and 'Custom' are removed from the definition, which is appropriate for simplifying the period selection.
1 participant
No description provided.