Merged
Conversation
Collaborator
ehwenk
commented
Mar 25, 2026
ehwenk
commented
- updated README and vignettes about APCalign
- small changes to new and revised functions following reviews
also corrected inconsistency in synonym function
render README
A collection of edits suggested by @dcol2804: - `native_anywere_in_australia` doesn't need the `include_infrataxa` parameter. It just needs the parameter set to T when it calls `create_species_state_origin_matrix`. If someone submits a infraspecific taxon name to the function, they'll expect to learn whether it is native or not. - `synonyms_for_accepted_names` now includes a message if the name submitted isn't an accepted name - stray character remove - specify that `synonyms_for_accepted_names` is for species/infraspecies, not genera or families (thanks Ruby)
also per @dcol2804 suggestion, changed columns slightly in synonym function added additional tests
Contributor
|
some very recent changes from hadley to how links work here: https://github.com/r-lib/roxygen2 maybe get most recent (development) version and re-do |
Contributor
|
test failing but i'm not sure if it's a regression...have a look tomorrow @ehwenk |
wcornwell
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.