Skip to content

Update GitHub Actions workflow with security improvements and linting #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dguido wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update GitHub Actions workflow with security improvements and linting #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ jobs:
contents: read
packages: write
steps:
- name: Checkout code
uses: actions/checkout@v5
with:
persist-credentials: false

- name: Lint Dockerfile
uses: hadolint/hadolint-action@v3
with:
dockerfile: Dockerfile
ignore: DL3007,DL3008,DL3013,DL3016
failure-threshold: warning

Comment on lines +25 to +36
Copy link
Member

@elopez elopez Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this its own workflow instead, that runs on pull requests to master and dev? This docker.yml only runs on a schedule and merges to master/dev only, and I feel like linting then is too late.

- name: Set up QEMU
uses: docker/setup-qemu-action@v3

Expand Down