Fix Dockerfile issues identified by hadolint #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SHELL directive with pipefail option to all build stages (DL4006) This ensures that piped commands fail properly if any command in the pipeline fails, preventing silent build failures - Use WORKDIR instead of cd for medusa build (DL3003) More idiomatic Docker practice that makes the build context clearer and follows Docker best practices These changes improve build reliability and follow Docker best practices without affecting the final image functionality. 🤖 Generated with Claude Code https://claude.ai/code Co-Authored-By: Claude <noreply@anthropic.com>
- Fix SC2155: Separate variable assignment from export to avoid masking command failures. Now if git describe fails, we can catch the error. - Fix SC2028: Replace echo with printf for consistent escape sequence handling across different systems. This ensures newlines are properly interpreted regardless of the shell implementation. These changes improve shell script reliability and portability within the Docker build process. 🤖 Generated with Claude Code https://claude.ai/code Co-Authored-By: Claude <noreply@anthropic.com>
Exclude unnecessary files from the Docker build context to improve build performance. This reduces the amount of data sent to the Docker daemon, speeding up builds. Excluded: - Git repository data (.git, .gitignore) - GitHub configuration (.github) - Documentation files (*.md, LICENSE, CODEOWNERS) - Build artifacts and temporary files 🤖 Generated with Claude Code https://claude.ai/code Co-Authored-By: Claude <noreply@anthropic.com>
Resolved conflict by: - Keeping Go 1.25 from master (latest version) - Keeping SHELL directive from our branch (hadolint fix) This combines the latest Go version update with our Dockerfile improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Dockerfile Improvements
Added SHELL directive with pipefail (fixes DL4006)
Use WORKDIR instead of cd (fixes DL3003)
WORKDIR /src/medusainstead ofcd medusaFix variable declaration (fixes SC2155)
git describefails, we can catch the errorReplace echo with printf (fixes SC2028)
Build Optimization
.dockerignorefile to exclude unnecessary files from build contextTesting
Hadolint Results
Before: 11 warnings, 4 info messages
After: 5 warnings (all version pinning - intentionally not fixed), 3 info messages
These changes improve build reliability without affecting functionality.
🤖 Generated with Claude Code
https://claude.ai/code