Skip to content

fix(sdk): @agent decorator no longer overwrites enclosing @workflow name #4288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dvirski wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

fix(sdk): @agent decorator no longer overwrites enclosing @workflow name #4288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/traceloop-sdk/traceloop/sdk/decorators/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,14 +137,12 @@ def _is_async_method(fn):

def _setup_span(entity_name, tlp_span_kind, version):
"""Sets up the OpenTelemetry span and context"""
if tlp_span_kind in [
TraceloopSpanKindValues.WORKFLOW,
TraceloopSpanKindValues.AGENT,
]:
if tlp_span_kind == TraceloopSpanKindValues.WORKFLOW:
set_workflow_name(entity_name)

if tlp_span_kind == TraceloopSpanKindValues.AGENT:
elif tlp_span_kind == TraceloopSpanKindValues.AGENT:
set_agent_name(entity_name)
if context_api.get_value("workflow_name") is None:

@galzilber galzilber Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const it please no magic strings

set_workflow_name(entity_name)
Comment on lines +144 to +145

@max-deygin-traceloop max-deygin-traceloop Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if "workflow_name" is none we set entity_name as workflow name.

But if it's not None? It's never set?


span_name = f"{entity_name}.{tlp_span_kind.value}"

Expand Down
Loading