Closed
Conversation
|
Preview (prod) → https://193-prod.rucq-ui-preview.trapti.tech/ |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an infinite redirect loop that could occur when the user is already on the /login path. When the API returns an opaque redirect (indicating authentication is required), the code now checks the current pathname before performing the redirect to /login.
Changes:
- Added a check to prevent redirecting to
/loginwhen already on that path - Changed from
window.location.hreftowindow.location.replacefor better history management
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit 594cfda.
mumumu6
force-pushed
the
fix/infinite-reload-without-cookie
branch
from
a3e9634 to
107b7cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/login にいる際にmain.tsの初期化をなくしました。
加えて/loginへのナビゲーションアクセスをnetworkonlyにしました