Skip to content

Implement IReadOnlyDictionary for DictionaryByValue and IReadOnlyList for ListByValue #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nouveau-nvc0 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Implement IReadOnlyDictionary for DictionaryByValue and IReadOnlyList for ListByValue #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Value/DictionaryByValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace Value.Shared
/// <remarks>This type is not thread-safe (for hashcode updates).</remarks>
/// <typeparam name="K">The type of keys in the dictionary.</typeparam>
/// <typeparam name="V">The type of values in the dictionary.</typeparam>
public class DictionaryByValue<K, V> : EquatableByValueWithoutOrder<DictionaryByValue<K, V>>, IDictionary<K, V>
public class DictionaryByValue<K, V> : EquatableByValueWithoutOrder<DictionaryByValue<K, V>>, IDictionary<K, V>, IReadOnlyDictionary<K, V>
{
private readonly IDictionary<K, V> dictionary;

Expand Down Expand Up @@ -132,5 +132,9 @@ public V this[K key]
public ICollection<K> Keys => dictionary.Keys;

public ICollection<V> Values => dictionary.Values;

IEnumerable<K> IReadOnlyDictionary<K, V>.Keys => dictionary.Keys;

IEnumerable<V> IReadOnlyDictionary<K, V>.Values => dictionary.Values;
}
}
2 changes: 1 addition & 1 deletion Value/ListByValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace Value
/// </summary>
/// <remarks>This type is not thread-safe (for hashcode updates).</remarks>
/// <typeparam name="T">Type of the listed items.</typeparam>
public class ListByValue<T> : EquatableByValue<ListByValue<T>>, IList<T>
public class ListByValue<T> : EquatableByValue<ListByValue<T>>, IList<T>, IReadOnlyList<T>
{
private readonly IList<T> list;

Expand Down