build!: migrate to type: "module"#137
Merged
toyobayashi merged 14 commits intomainfrom Mar 24, 2025
Merged
Conversation
type: "module" (WIP)type: "module"
toyobayashi
added a commit
that referenced
this pull request
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although I think node16 not respecting
__esModulemakes the interoperability of ESM and CJS quite messy between runtime and bundler / TypeScript Compiler, it is undeniable that the community will continue move forward.This PR changes the bundled files of emnapi packages to
If runtime doesn't recognize
module-synccondition, default resolve to CJS no matter usingimportorrequireto avoid dual-package hazard.{ "type": "module", "main": "./dist/[name].cjs", "module": "./dist/[name].js", "types": "./dist/[name].d.ts", "exports": { ".": { "types": { "module": "./dist/[name].d.ts", "module-sync": "./dist/[name].d.ts", "import": "./dist/[name].d.cts", "require": "./dist/[name].d.cts", "default": "./dist/[name].d.cts" }, "module": "./dist/[name].js", "module-sync": "./dist/[name].js", "default": "./dist/[name].cjs" } } }When ESM becomes large enough in the community, I will migrate it to a pure ESM package.