🐛 fix(oci): parse Bearer parameters#232
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
cc91de4 to
0e53b36
Compare
This was referenced Jul 13, 2026
0e53b36 to
fe94e4c
Compare
Peryx failed OCI token exchange when registries sent quoted commas or mixed-case authentication parameter names. It also forwarded backslash escapes verbatim. Peryx parses authentication parameters in one pass under RFC 9110. It preserves existing realm queries with `url::Url` when appending token request parameters. Fixes tox-dev#224
fe94e4c to
2db4069
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peryx split commas inside quoted values as parameter separators, which truncated realm URLs. It dropped mixed-case fields and forwarded quoted-pair escapes to the token server. This closes #224.
Peryx now scans each challenge once under RFC 9110, parses token and quoted-string values, then decodes quoted pairs. Parameter names use ASCII-insensitive comparisons.
url::Urlpreserves existing realm query parameters before Peryx adds scope and service.