🐛 fix(backup): preserve effective config#230
Merged
gaborbernat merged 1 commit intoJul 13, 2026
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
daa1c67 to
26451f9
Compare
6ff6477 to
179dccf
Compare
Backup snapshots omitted most resolved settings. Restoring the file could change an OCI index into PyPI or discard its private-read controls. Serialize the resolved configuration while retaining each secret source. Exhaustive destructuring makes configuration additions fail compilation until the snapshot format handles them. Fixes tox-dev#197
179dccf to
79e605f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backup snapshots serialized only a subset of the resolved configuration, so restoring one could change an OCI index to PyPI and discard the remaining operator settings. This closes #197.
The snapshot now serializes every resolved field and preserves each secret source. It borrows resolved values where possible, and exhaustive destructuring makes future configuration additions a compile error until backup serialization handles them.