Skip to content

🐛 fix(oci): refresh search after tag changes#229

Merged
gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/oci-search-refresh
Jul 13, 2026
Merged

🐛 fix(oci): refresh search after tag changes#229
gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/oci-search-refresh

Conversation

@gaborbernat

@gaborbernat gaborbernat commented Jul 13, 2026

Copy link
Copy Markdown
Member

Users who searched after an OCI tag write saw the prior index. Results omitted new repositories and retained deleted tags until a PyPI mutation or process restart. This closes #196.

Package search tracks its own generation, separate from rendered-page caches. OCI tag transactions advance that generation when they add or remove a tag name. Digest replacements keep the tag set intact and avoid an index rebuild; digest deletion clears matching tag and referrer records in one transaction.

@gaborbernat gaborbernat added bug Something isn't working priority:P1 Protocol parity or important product gap type:bug Incorrect behavior or missing validation area:search Package search and indexing labels Jul 13, 2026
@gaborbernat gaborbernat self-assigned this Jul 13, 2026
@read-the-docs-community

read-the-docs-community Bot commented Jul 13, 2026

Copy link
Copy Markdown

@gaborbernat gaborbernat force-pushed the fix/oci-search-refresh branch 3 times, most recently from a427466 to 6b16890 Compare July 13, 2026 15:45
@codspeed-hq

codspeed-hq Bot commented Jul 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 29 untouched benchmarks
⏩ 91 skipped benchmarks1


Comparing gaborbernat:fix/oci-search-refresh (24e8839) with main (65d9ca0)

Open in CodSpeed

Footnotes

  1. 91 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

OCI tag changes left search stale after its first build. New repositories
stayed absent, and deleted tags remained visible until a PyPI mutation.

Give package search a generation separate from page caches. Advance it when
the searchable tag-key set changes, avoiding index rebuilds for digest
replacements.

Fixes tox-dev#196
@gaborbernat gaborbernat force-pushed the fix/oci-search-refresh branch from 04a168b to 24e8839 Compare July 13, 2026 19:23
@gaborbernat gaborbernat marked this pull request as ready for review July 13, 2026 19:48
@gaborbernat gaborbernat merged commit 1519705 into tox-dev:main Jul 13, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:search Package search and indexing bug Something isn't working priority:P1 Protocol parity or important product gap type:bug Incorrect behavior or missing validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(oci): refresh search after mutations

1 participant