Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Ktor integration to the Kermit logging library, allowing users to integrate Kermit with Ktor's HTTP client logging. It also includes a typo fix in the Koin documentation.
- Adds a new
kermit-ktorextension module withKermitKtorLoggerclass - Includes documentation for the new Ktor integration
- Updates build configuration to include the new module
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/kermit-ktor/src/commonMain/kotlin/co/touchlab/kermit/ktor/KermitKtorLogger.kt | Core implementation of Ktor logger adapter |
| extensions/kermit-ktor/build.gradle.kts | Build configuration for the new module |
| extensions/kermit-ktor/api/kermit-ktor.api | API definition file |
| extensions/kermit-ktor/README.md | Module README documentation |
| website/docs/extensions/KTOR.md | Web documentation for Ktor integration |
| website/docs/extensions/index.md | Added Ktor entry to extensions index |
| website/docs/extensions/KOIN.md | Fixed typo in "integration" |
| settings.gradle.kts | Registered new module in Gradle settings |
| gradle/libs.versions.toml | Added Ktor dependency version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 9357b3d.
samhill303
approved these changes
Nov 5, 2025
faogustavo
reviewed
Nov 19, 2025
faogustavo
reviewed
Nov 19, 2025
extensions/kermit-ktor/src/commonMain/kotlin/co/touchlab/kermit/ktor/KermitKtorLogger.kt
Outdated
Show resolved
Hide resolved
faogustavo
approved these changes
Nov 19, 2025
…t/ktor/KermitKtorLogger.kt Co-authored-by: Gustavo Fão Valvassori <faogustavo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Ktor integration for the Kermit logging library, allowing Kermit to be used as a logger within Ktor HTTP clients across multiple platforms. It adds a new
kermit-ktormodule, provides documentation, and updates the project configuration to support this extension.Ktor Integration Feature:
kermit-ktormodule, including multiplatform source sets and dependencies, enabling Kermit to be used as a logger in Ktor clients.KermitKtorLoggerclass, which adapts Kermit's logging API to Ktor'sLoggerinterface, supporting configurable severity and logger instances.