Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Android app to support edge-to-edge display by enabling modern window insets handling and removing the deprecated Accompanist Navigation Animation library.
Key changes:
- Enabled edge-to-edge display mode in MainActivity
- Updated Compose Navigation library from 2.8.9 to 2.9.5
- Removed Accompanist Navigation Animation dependency
- Standardized parameter naming for padding values in Compose lambdas
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| android/src/main/java/co/touchlab/droidcon/android/MainActivity.kt | Added enableEdgeToEdge() call to support modern window insets |
| shared-ui/src/androidMain/kotlin/co/touchlab/droidcon/ui/util/MainView.kt | Removed systemBarsPadding() modifier to work with edge-to-edge |
| shared-ui/src/commonMain/kotlin/co.touchlab.droidcon/ui/BottomNavigationView.kt | Renamed paddingValues to innerPadding for consistency |
| shared-ui/src/commonMain/kotlin/co.touchlab.droidcon/ui/session/SessionListView.kt | Renamed paddingValues to innerPadding for consistency |
| shared-ui/src/commonMain/kotlin/co.touchlab.droidcon/ui/theme/Theme.kt | Simplified when expression to if-else for two-branch condition |
| gradle/libs.versions.toml | Updated Compose Navigation version and removed Accompanist dependency |
| android/build.gradle.kts | Removed Accompanist implementation dependency |
| android/src/main/res/values/themes.xml | Fixed empty XML tag formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| WindowCompat.setDecorFitsSystemWindows(window, false) | ||
|
|
There was a problem hiding this comment.
The enableEdgeToEdge() call is redundant. WindowCompat.setDecorFitsSystemWindows(window, false) on line 71 already achieves the same effect as enableEdgeToEdge(). The enableEdgeToEdge() function internally calls WindowCompat.setDecorFitsSystemWindows(window, false), making one of these calls unnecessary. Consider removing line 71 and keeping only enableEdgeToEdge(), as it's the newer, more idiomatic approach.
| WindowCompat.setDecorFitsSystemWindows(window, false) |
|
Can you provide screenshots for evidence? I don't have enough information from the PR to tell what to look for. |
3ae0be9 to
14a5ae8
Compare

No description provided.