PaymentMethod.PaymentInfo 데이터 모델 개선#17
Open
sieunju wants to merge 70 commits intotosspayments:developfrom
Open
PaymentMethod.PaymentInfo 데이터 모델 개선#17sieunju wants to merge 70 commits intotosspayments:developfrom
sieunju wants to merge 70 commits intotosspayments:developfrom
Conversation
Co-authored-by: sybock <68641631+sybock@users.noreply.github.com>
[CP-203] [Android] Native SDK 약관 위젯 추가
Issue/update amount
- 해외 결제 지원 (renderPaymentMethods 메서드, 두번째 파라미터 amount에 금액, 통화, 나라 추가) - 멀티 UI 스펙 (renderPaymentMethods 메서드, 세번째 파라미터 variantKey 추가)
renderPaymentMethods 스펙 추가
widgetStatus 메세지 추가
- widget status listener 구현 및 예제 적용
# Conflicts: # app/src/main/java/com/tosspayments/paymentsdk/sample/activity/PaymentWidgetActivity.kt # app/src/main/java/com/tosspayments/paymentsdk/sample/activity/PaymentWidgetInfoActivity.kt # app/src/main/res/layout/activity_payment_widget.xml # app/src/main/res/layout/activity_payment_widget_info.xml # paymentsdk/src/main/java/com/tosspayments/paymentsdk/PaymentWidget.kt # paymentsdk/src/main/java/com/tosspayments/paymentsdk/model/PaymentWidgetStatusListener.kt # paymentsdk/src/main/java/com/tosspayments/paymentsdk/view/PaymentWidgetContainer.kt
feature/pwd-225 : 에러 수신 interface 변경
- 결제 위젯에서 발생하는 Error Event 수신이 안되는 이슈 수정
- Builder 패턴 방식으로 변경
feature/cp-371 : getSelectedPaymentMethod, PaymentWidgetAndroidSDK.error 추가
* 샘플 앱 redirectUrl 반영 안 되는 문제 수정 * selectedPaymentMethod 로깅 시점 변경
- 카드사 결제 페이지에서 취소 시 에러 화면으로 이동하는 이슈 수정
* feat: 결제창 v1 js 스크립트 주소 최신화 * feat: staging, dev 빌드 환경의 결제창 html 추가 * feat: TossCardPaymentInfo에 currency 필드 추가 * feat: 샘플 앱 currency 선택 지원
- Builder 패턴 방식으로 변경
…o feature/refactor_data_model # Conflicts: # paymentsdk/src/main/java/com/tosspayments/paymentsdk/view/PaymentMethod.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[REFACTOR] PaymentMethod Widget 에서 결제 요청시 사용하는
PaymentMethod.PaymentInfo구조 변경안이유
orderId, orderName필수로 받던 처리에 대하서도 지원을 하면서 Deprecated 추가하여 Builder 방식으로 유도 할수 있도록 주석 추가ps. 실제 저희 서비스에서 해당 SDK 사용하다가 "이방식으로 하면 어떨까?"라는 생각에 제안 드려봅니다. 🙇♂️