Skip to content

fix: make @granite-js/video compatible with react-native-video@6.0.0#245

Merged
l2hyunwoo merged 13 commits intomainfrom
fix-video-props
Apr 1, 2026
Merged

fix: make @granite-js/video compatible with react-native-video@6.0.0#245
l2hyunwoo merged 13 commits intomainfrom
fix-video-props

Conversation

@jingjing2222
Copy link
Copy Markdown
Collaborator

@jingjing2222 jingjing2222 commented Mar 25, 2026

Summary

  • Fix @granite-js/video native component types to be compatible with react-native-video@6.0.0
  • Add missing fields to DRM config (headers, multiDrm), CMCD config (request, session, object, status), and Ads config (adTagParameters)
  • Add event handlers: onAudioTracks, onTextTracks, onTextTrackDataChanged, onVideoTracks, onTimedMetadata, onReceiveAdEvent
  • Add progressUpdateInterval and textTracks props
  • Rename source fields: startPosition/cropStart/cropEnd → startTime/endTime
  • Add live option to bufferConfig; remove unnecessary normalize functions (normalizeDrm, normalizeBufferConfig)
  • Remove forced empty tracks injection in onLoad handler
  • Remove unused data field from OnReceiveAdEventData

Test plan

  • Verify DRM content playback with headers passed correctly
  • Verify source playback with CMCD configuration
  • Verify ad playback with adTagParameters and onReceiveAdEvent
  • Verify onAudioTracks, onTextTracks, onVideoTracks callbacks fire correctly
  • Verify startTime/endTime segment playback
  • Verify bufferConfig.live settings applied
  • No regression on existing playback functionality

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 25, 2026

🦋 Changeset detected

Latest commit: d1b54a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@granite-js/video Patch
@granite-js/native Patch
@granite-js/react-native Patch
@granite-js/blur-view Patch
@granite-js/jest Patch
@granite-js/style-utils Patch
babel-preset-granite Patch
create-granite-app Patch
@granite-js/cli Patch
@granite-js/cookies Patch
@granite-js/screen Patch
@granite-js/image Patch
@granite-js/lottie Patch
@granite-js/mpack Patch
@granite-js/naver-map Patch
@granite-js/plugin-core Patch
@granite-js/plugin-env Patch
@granite-js/plugin-hermes Patch
@granite-js/plugin-micro-frontend Patch
@granite-js/plugin-router Patch
@granite-js/plugin-rozenite Patch
@granite-js/plugin-sentry Patch
@granite-js/utils Patch
@granite-js/deployment-manager Patch
@granite-js/forge-cli Patch
@granite-js/pulumi-aws Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
granite-docs Ready Ready Preview, Comment Mar 31, 2026 5:54pm

Request Review

@l2hyunwoo l2hyunwoo merged commit dcffed6 into main Apr 1, 2026
7 checks passed
@l2hyunwoo l2hyunwoo deleted the fix-video-props branch April 1, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants