fix[isBuffer]: add browser export condition to avoid 44KB Buffer polyfill#1671
Open
fix[isBuffer]: add browser export condition to avoid 44KB Buffer polyfill#1671
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jantimon
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a browser-safe build path for isBuffer to prevent bundlers (e.g. webpack/Next.js, Vite) from injecting large Buffer polyfills, and refactors internal call sites to use the centralized predicate.
Changes:
- Introduces
isBuffer.browser.tsstub and a Rollup alias to swap it into the browser ESM/UMD builds. - Adds
browserexport conditions for top-level subpath exports inpublishConfig.exports. - Replaces inline
Bufferchecks in several utilities (isEqualWith,cloneDeepWith,isEmpty,mergeWith) withisBuffer().
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/predicate/isEqualWith.ts | Refactors Buffer detection in typed-array comparison to use isBuffer(). |
| src/predicate/isBuffer.browser.ts | Adds browser-safe isBuffer stub used by the browser build. |
| src/object/cloneDeepWith.ts | Switches Buffer cloning branch to use centralized isBuffer(). |
| src/compat/predicate/isEmpty.ts | Replaces inline Buffer check with isBuffer() in compat isEmpty. |
| src/compat/object/mergeWith.ts | Uses isBuffer() when deciding whether to deep-clone Buffer source values. |
| rollup.config.mjs | Adds browser ESM build output + alias plugin wiring for isBuffer stub. |
| package.json | Adds browser conditional export mappings under publishConfig.exports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isBufferstub (() => false) and a rollup alias plugin that swaps it in during the browser buildbrowserexport condition to every subpath inpackage.jsonso bundlers like webpack/vite pick up the polyfill-free build automaticallytypeof Buffer/Buffer.isBuffer()checks acrossmergeWith,isEmpty,cloneDeepWith, andisEqualWithto use the centralizedisBufferfunctioncloses #1670
Build size comparison (Next.js test app)
Webpack
Turbopack
Test plan
yarn vitest run— all existing tests pass (isBuffertests run against the real Node.js implementation)yarn lint/tsc --noEmit— clean.next/staticdrops from 492K to 464K after the changegrep -r "Buffer" dist/browser/confirms no Buffer references in the browser build