fix(compat/isMatchWith): align nested primitive matching with lodash in isMatchWith#1647
Open
fix(compat/isMatchWith): align nested primitive matching with lodash in isMatchWith#1647
Conversation
Keep root-level primitive-vs-object behavior, but use strict equality for nested comparisons. This fixes false positives in matches/isMatch/isMatchWith.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the compat/predicate/isMatchWith implementation to better match Lodash behavior by preventing nested primitive-vs-object comparisons from returning false positives, while preserving the existing root-level behavior.
Changes:
- Introduced an
isRootflag inisMatchWithInternalto distinguish root vs nested primitive matching semantics. - Updated recursion paths to pass
isRootappropriately (root calltrue, nested recursionfalse). - Added regression tests for
matches,isMatch, andisMatchWithcovering nested primitive-vs-object mismatches.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/compat/predicate/isMatchWith.ts | Adds root-awareness to internal matching so nested primitive/object mismatches use strict equality. |
| src/compat/predicate/matches.spec.ts | Adds regression test for nested primitive source vs object target mismatch. |
| src/compat/predicate/isMatch.spec.ts | Adds regression test ensuring isMatch no longer returns a false positive for nested primitive/object mismatch. |
| src/compat/predicate/isMatchWith.spec.ts | Adds regression test for isMatchWith nested primitive/object mismatch when customizer yields undefined. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep root-level primitive-vs-object behavior, but use strict equality for nested comparisons. This fixes false positives in matches/isMatch/isMatchWith.