fix(compat/isEmpty): handle functions with own enumerable properties#1645
Open
fix(compat/isEmpty): handle functions with own enumerable properties#1645
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes compat/predicate/isEmpty behavior to match lodash when the input is a function that has own enumerable properties (e.g., knex transactions), addressing issue #1638.
Changes:
- Treat
typeof value === 'function'similarly to objects soObject.keysis checked. - Add a regression test ensuring functions with attached enumerable properties are not considered empty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/compat/predicate/isEmpty.ts |
Extends the “object” handling branch to include functions so enumerable properties are detected. |
src/compat/predicate/isEmpty.spec.ts |
Adds a regression test for functions with attached enumerable properties. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }); | ||
|
|
||
| it('should return `false` for functions with own enumerable properties', () => { | ||
| function transaction() {} |
D-Sketon
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1645 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 497 497
Lines 4660 4660
Branches 1348 1348
=======================================
Hits 4659 4659
Misses 1 1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1638